multiformats icon indicating copy to clipboard operation
multiformats copied to clipboard

About the circular (install) dependency between multiformats and multiformats-config

Open declension opened this issue 1 year ago • 4 comments

First of all, thanks for the repo(s)!

I'm using Poetry, and that lead me to notice that multiformat depends on multiformat-config at least at build time, and also, multiformat-config depends on multiformat.

Clearly this isn't technically a problem in Python, but whilst I'm not an expert, it does seem that in Nix it causes trouble (an example with poetry2nix)

Is this a Nix problem, or is there anything that can be done here?

Thanks

declension avatar Jul 15 '24 20:07 declension

In this case, this seems to be an issue on the Nix side rather than the Python side. But really it is an issue with the current design of multiformats, which pre-initialises its data structures rather than initialising them on-demand. I will re-design the init process at some point in the near future, which will remove the need for multiformat-config altogether. Is this something that is causing you issues right now?

sg495 avatar Jul 20 '24 11:07 sg495

Thanks @sg495 .

It's a non-critical issue I guess, as due the now-solved #10 we'd implemented the bits of the spec we needed manually in Python.

I recently tried pulling in this library again but given we package with Nix ran into this so have paused / halted that idea...

declension avatar Jul 22 '24 11:07 declension

No problem. I'll keep this open as a reminder to us of the issue, and I'll @ you when it's fixed.

sg495 avatar Jul 24 '24 10:07 sg495

Thanks for providing this repo from my side as well!

We were trying to packages mutliformats for conda-forge at https://github.com/conda-forge/staged-recipes/pull/28790. However, we've been stumbling about the circular-depencency problem there as well. Do you already have updates on this issue?

d70-t avatar Jan 27 '25 16:01 d70-t