namedtensor icon indicating copy to clipboard operation
namedtensor copied to clipboard

Added more pooling layers to torch_nn.py

Open suzgunmirac opened this issue 6 years ago • 4 comments
trafficstars

I realized that six of the pooling layers in torch.nn were initially missing, so I added them to torch_nn.py.

suzgunmirac avatar Feb 01 '19 16:02 suzgunmirac

Looks great, but lint tests are failing. Be sure to run format.sh first.

srush avatar Feb 01 '19 17:02 srush

Also be careful. MaxUnpool needs to indices, so it is not going to work.

input: the input Tensor to invert
indices: the indices given out by MaxPool3d

srush avatar Feb 01 '19 17:02 srush

Changed around the nn style a bit. maybe we can update avg pool to the new style.

(honestly though we won't use any of these this assignment, they're more for images)

srush avatar Feb 01 '19 22:02 srush

Thank you so much for the update, Professor Rush! In this case, I will update the pooling layers once we finalize the nn style.

suzgunmirac avatar Feb 01 '19 22:02 suzgunmirac