grub2-theme-preview
grub2-theme-preview copied to clipboard
hartwork
Option "--resolution=" does not work
When i use the --resolution option it does not work. I compared both outputs with --debug and noticed that your program puts the "set gfxmode=" to the top. But down the line the original "set gfxmode=auto" is still there! So it sets it to my resolution, but further down the line it is set back to auto.. Maybe it would be better if your program first search for an existing, and if found then replace it. If not found, then set to the top were it is now.
@Lowrida that's a nice report, we will need to get rid of the set gfxmode=auto then I guess. Thanks! :+1:
@Lowrida there is pull request #65 now with instructions how to try it out locally. Please let me know if this fix makes things work for you. Thanks! :+1:
Btw i tried a custom grubconfig with "set gfxmode=auto" replaced by a resolution and it still does not change the qemu window! So i thought, maybe it should be on top. I then moved the line to the top of the custom grub config and still the qemu window size stays the same! For some reason it refuses to resize the qemu window!
I did not try the pull, because i don't know how to do that.. i have very little knowledge about github. I know how to copy a source to my disk and how to open an issue ;)
@Lowrida you could try with display gtk or with display sdl and see if either is affected. I'm unsure which one you have, and defaults vary.
I put precise instructions at https://github.com/hartwork/grub2-theme-preview/pull/65#issue-1222148529 . With those, it should be running off the branch in 5 seconds.
I tried all the display options, but that made no difference. On my system i get the "sdl is not supported" message. Only gtk does not gave me an error, but also did nothing to change any resolution.
For what it's word. I manually edited a custom grub config and removed all the "set gfxmode=" lines and added a new one on top of the config and tested that with any resolution possible and it does not change anything! The resolution thing does nothing at all on my system i guess.
But now that i have fullscreen mode working, for me this is less important.
As i said in another post. If your solution will fix the bug you should implement it in an upcoming update!
@Lowrida the way I read https://github.com/hartwork/grub2-theme-preview/issues/63#issuecomment-1114306192 problem "--resolution= not working" should be gone now when passing --vga virtio with version 2.7.0. Can you confirm?
@Lowrida the way I read #63 (comment) problem "--resolution= not working" should be gone now when passing
--vga virtiowith version 2.7.0. Can you confirm?
@Lowrida can you confirm?
Hi, sorry for my late response, i totally missed your previous post! I will let you know asap!
edit: Funny.. i have no clue how i got your program installed last time? I can't seem to get it to update!? I have cloned the git, but not clear how to make it.. with pip says it does, but when i check the program it is still the old one without the 2 extra options.
@Lowrida the way I read #63 (comment) problem "--resolution= not working" should be gone now when passing
--vga virtiowith version 2.7.0. Can you confirm?@Lowrida can you confirm?
@Lowrida any news?
Closing because of no response for months. Happy to re-open if the issues turns out to still exist on master.
And this was no respons???
Hi, sorry for my late response, i totally missed your previous post! I will let you know asap!
edit: Funny.. i have no clue how i got your program installed last time? I can't seem to get it to update!?
I have cloned the git, but not clear how to make it.. with pip says it does, but when i check the program it is still the old one without the 2 extra options.
edit: Funny.. i have no clue how i got your program installed last time? I can't seem to get it to update!? I have cloned the git, but not clear how to make it.. with pip says it does, but when i check the program it is still the old one without the 2 extra options.
@Lowrida if you're still interested, there are detailed instructions at https://github.com/hartwork/grub2-theme-preview/pull/65#issue-1222148529 installing into a fresh virtualenv. Just the clone statement will need slight adjustment.