Sebastian Pipping
Sebastian Pipping
@kaixiong complement in function yes, but lv_scope has some charm and even a starfield background on `master` to be backported to 0.4.x while lv_analyzer has bars that are hardly visible...
@kaixiong PS: Also please let's not merge them.
> @hartwork, I'm fine with keeping the two actors separate and keep lv_analyzer out of the default cycle. @kaixiong thank you! > I definitely want to preserve and enhance lv_analyzer...
@kaixiong I agree and already played a bit with client code but it's a bit of bumpy road, and https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/2997 only is the start of it. If it was less...
PS: What I find interesting is how they hand out and take in buffers with `pw_stream_dequeue_buffer` and `pw_stream_queue_buffer`.
@kaixiong we definitely need a way to support asynchronous input APIs out of the box, I agree.
> @hartwork I would prefer to apply this first to Core only @kaixiong why only fix it in half the code? >, extracting as much of the pre-existing style into...
> I'm okay with applying Core's formatting to the others (input and morph). @kaixiong is my understanding correct that actors starting from existing multi-file code would then not be discussed...
> @hartwork I'm skeptical of how useful that is. At least two actors are doing something like that, I can make a list, if you like. > I would prefer...
> @hartwork, yes it would be good to quantify. I certainly would be quite surprised to learn otherwise because updating state based on a variable interval is always more work...