Sebastian Pipping

> That affects only `XML_Parse`, since with `XML_ParseBuffer` the user is manually managing the buffer anyway, right? I think it does affect `XML_ParseBuffer` because you still need to pick a...

> _If_ this understanding is correct, then this could be solved by modifying [`XML_GetBuffer`](https://github.com/libexpat/libexpat/blob/515f5d07c698d041cad5ec868002e6497be1c764/expat/lib/xmlparse.c#L1949) to detect whether or not resizing the buffer would cause an overflow or not, then emitting...

Hi @fbergmann , for now I am unsuere what may be wrong and if there is a bug. Let's find out! Let me do a quick braindump here: - I...

@fbergmann PS: I found that builds with earlier releases of MSVC already show the LNK4217 link errors your mention and despite `/WX` they do not make the link fail. If...

@fbergmann PPS: - AppVeyor does have MSVC 2022, they introduced it at https://www.appveyor.com/blog/2021/11/10/visual-studio-2022-image/ . - When I make AppVeyor build with your config, I get no error, see: - the...

> In the end my problem went away using the option command instead: So that is disabling caching of the option? Before I understand the full picture here, this seems...

> No .. it just means, that currently a user defined value of `EXPAT_MSVC_STATIC_CRT ` is just overridden by the `set` command. using the `option` statement, the value is still...

> for me it is just an inconsistency, for all other configuration options i can just call > > ``` > set (EXPAT_SHARED_LIBS OFF) > set (EXPAT_BUILD_EXAMPLES OFF) > set...

> It was a warning in your own test cases, i'm ok with them not being fixed. both your runtests and runtestcpp project you linked were missing the XML_STATIC define,...

@fbergmann update on that^^: I fixed something and now LNK4217 seems indeed gone. That's pull request #599 now.