Oliver Hartkopp

Sorry for the mess in this review. It was the first time where I not only added single comments but used the "start a review" button ... Thanks for the...

Isn't this already part of isotpdump?

Just to follow up on this pending discussion: First the use of the "human readable" candump output is a bad idea as it would make much more sense to use...

> @hartkopp ISO-TP is transport protocol (like TCP in TCP/IP stack), while UDS is application layer. ISO-TP can carry different data than UDS, however, most common use case is actually...

The socketcand was intended for interactive control of CAN data from a host that wants to access CAN interfaces remotely. A more efficient SocketCAN tunneling is provided by the https://github.com/mguentner/cannelloni...

That does not address my general concerns on this topic. IMO a `j1939-vehicle-position-srv` has no justification to be in can-utils.

Thanks! I'm not sure which j1939 applications make sense to remain in can-utils. I'm not generally against j1939 tools here - but it should be something on the level of...

Yes, those are the really big chunks that are already clustered in directories. @olerem , would this be ok for you too? @marckleinebudde does it make sense to split up...

I was thinking of libj1939.h and libj1939.c AFAICS either `$PROGRAMS_J1939` are referencing this code as well as `isobusfs`, `j1939_vehicle_position`, `j1939_timedate`

I have seen, that you can have a git repository where you have e.g. a directory which points to another git repo with a specific commit. A bit like a...