snip icon indicating copy to clipboard operation
snip copied to clipboard

Published 20 hours ago • verified publisher icon harshhhdev

[FEATURE] Migrate onto React 18

Open haaarshsingh opened this issue 3 years ago • 7 comments

Is your feature request related to a problem? Please describe. Currently, we're unable to use features such as Suspense because Next.js does not support it on React versions that are below 18.

Describe the solution you'd like I would like to upgrade this repository to use React 18.

Additional context None.

haaarshsingh avatar Aug 24 '22 23:08 haaarshsingh

Hi @harshhhdev, I would like to take a try on migrating to React v18. Could you please assign this to me?

timagixe avatar Aug 25 '22 05:08 timagixe

Hey @timagixe, sure thing! Feel free to open a pull request once you're ready.

haaarshsingh avatar Aug 25 '22 16:08 haaarshsingh

@harshhhdev could you please assign it to me, so I won't miss it and could track it by the link https://github.com/issues/assigned. Thank you!

timagixe avatar Aug 25 '22 19:08 timagixe

Hey @timagixe, I thought I had assigned it to you but apparently not :thinking:. GitHub might've glitched. Anywho, it's assigned now. Good luck!

haaarshsingh avatar Aug 25 '22 22:08 haaarshsingh

Hi @harshhhdev, I am taking this into work today, I will leave questions here if I face some issues or troubles.

timagixe avatar Sep 20 '22 10:09 timagixe

While upgrading react to v18, I also had to upgrade framer-motion to the latest one because of TS compiler was throwing errors like this https://github.com/framer/motion/pull/1573.

timagixe avatar Oct 29 '22 19:10 timagixe

If I recall correctly, there's also an issue with Framer Motion and the types library on React 18.

haaarshsingh avatar Oct 29 '22 21:10 haaarshsingh