Harry Sarson

Results 153 comments of Harry Sarson

I see there is a "breaking" label, with this option: https://github.com/elm/core/issues/1082#issuecomment-615234194 it doesn't _have_ to be a breaking change.

Here is the travis failure: https://travis-ci.org/github/elm/core/builds/765919223. Travis also fails on master :worried:

``` ✖ fatal HttpError: Resource not accessible by integration at /node_modules/@octokit/request/lib/request.js:56:27 at processTicksAndRejections (internal/process/task_queues.js:93:5) at async Object.doComment [as comment] (/entrypoint.js:47:5) ``` The GH action does not seem to work. Pinging...

CI does pass: . Not sure why GH does not display it 🤷

This is still an issue in elm 0.19. Here is @zwilias's **sscce** updated for 0.19: ```elm module Main exposing (..) import Html exposing (text) import Process import Task exposing (Task)...

Applogies: the sscce above has not infact been updated for elm 19. This one has: https://ellie-app.com/4CzFx6NYkrSa1 ```elm module Main exposing (..) import Html exposing (text) import Process import Task exposing...

As the one who released the offending version of elm-test, sorry!

I put a PR up at #1104 which is one way to fix this. @mpizenberg had a good idea on discord for how to keep using node-test-runner to run tests...

#1104 is now ready (from my end) to land. It is the minimal PR that fixes `./tests/run-tests.sh`. A follow up PR to migrate the CI to github actions (or to...