drone-cli icon indicating copy to clipboard operation
drone-cli copied to clipboard

Implement snap packaging

Open brlin-tw opened this issue 5 years ago • 3 comments
trafficstars

This pull request implements the necessary changes to package drone-cli as a snap, Snaps are universal linux packages.

This PR should supersede #122 in terms of completeness, credits goes to @mikeroyal who provides most if not all the details needs to be taken care of, though this PR includes the following notable changes:

  • Changing the snap and command name from drone-cli to drone to match documented usage

  • Using my selective checkout scriptlet to checkout and build latest tagged release if the stable channel yet have one

  • (Hopefully) Fix version tagging:

    $ drone --version
    drone version 1.2.1-6-geef6428-dirty
    
  • Using my locales-launch launcher script to fix locales at runtime

  • Adding an app-specific maintenance launcher to check confinement status and for future conveniences.

This snap has been successfully built on amd64, armhf, and arm64 architectures, and is runnable on an amd64 system.

Signed-off-by: 林博仁(Buo-ren, Lin) [email protected]

brlin-tw avatar Mar 31 '20 16:03 brlin-tw

Some notes regarding the snap name:

brlin-tw avatar Mar 31 '20 17:03 brlin-tw

This looks good 🥇 we have created a proposal https://github.com/drone/proposal/issues/4 to gauge support for this feature, as we would need to setup the infrastructure / support for maintaining this going forward. If you want it give it a 👍

tphoney avatar Jul 20 '21 15:07 tphoney

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 19 '22 06:01 CLAassistant

This PR has been automatically closed due to inactivity.

bot-harness avatar Oct 19 '23 11:10 bot-harness