python-can icon indicating copy to clipboard operation
python-can copied to clipboard

socketcan: Make find_available_interfaces() find slcanX interfaces

Open msalau opened this issue 3 years ago • 1 comments

Hello,

This change allows can.detect_available_configs(['socketcan']) find not just canX and vcanX interfaces, but also slcanX interfaces too. Such names are given by default to interfaces that are created using the slcand utility.

The module has an option to work with SLCAN adapters directly, but creating a SocketCAN interface instead can be beneficial too (e.g.: make it possible to use Wireshark, can-utils, cantools and etc.). For this reason I added few lines to the doc about how to use SLCAN adapters with socketcan.

Regards, Maksim

msalau avatar Aug 10 '22 18:08 msalau

Codecov Report

Merging #1369 (d1aafbe) into develop (9d9cb16) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1369   +/-   ##
========================================
  Coverage    66.25%   66.25%           
========================================
  Files           86       86           
  Lines         9021     9021           
========================================
  Hits          5977     5977           
  Misses        3044     3044           

codecov[bot] avatar Aug 11 '22 07:08 codecov[bot]

@hartkopp @zariiii9003 Please approve CI so the review can move on eventually :) All the tests passed in my forked repository (only codecov upload failed due to missing token).

Thanks, Maksim

msalau avatar Sep 02 '22 21:09 msalau

@hartkopp @zariiii9003 Please approve CI so the review can move on eventually :) All the tests passed in my forked repository (only codecov upload failed due to missing token).

Thanks, Maksim

Looks good to me! Reviewed-by: Oliver Hartkopp [email protected]

hartkopp avatar Sep 03 '22 09:09 hartkopp