python-can icon indicating copy to clipboard operation
python-can copied to clipboard

Ixxat bus state and hardware errors detection

Open cowo78 opened this issue 4 years ago • 7 comments

Implemented IXXATBus.state() property. Hardware errors are detected in _recv_internal() and raise an exception.

cowo78 avatar Oct 18 '21 08:10 cowo78

Codecov Report

Merging #1141 (f92a056) into develop (8c4ed5f) will decrease coverage by 0.07%. The diff coverage is 30.26%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
- Coverage    65.28%   65.20%   -0.08%     
===========================================
  Files           81       81              
  Lines         8832     8853      +21     
===========================================
+ Hits          5766     5773       +7     
- Misses        3066     3080      +14     

codecov[bot] avatar Oct 18 '21 08:10 codecov[bot]

#1119 created some conflicts

felixdivo avatar Dec 07 '21 19:12 felixdivo

@cowo78 I can do a review once they are resolved.

felixdivo avatar Dec 07 '21 19:12 felixdivo

Am I right in that this only adds bus.state support for can/interfaces/ixxat/canlib_vcinpl1.py and not for can/interfaces/ixxat/canlib_vcinpl2.py?

felixdivo avatar Dec 22 '21 08:12 felixdivo

Am I right in that this only adds bus.state support for can/interfaces/ixxat/canlib_vcinpl1.py and not for can/interfaces/ixxat/canlib_vcinpl2.py?

Correct. As mentioned in #1119 I would suggest to postpone a refactoring / code deduplication do another PR.

cowo78 avatar Dec 22 '21 10:12 cowo78

I'd like this to get a single other review before merging.

felixdivo avatar Jan 15 '22 20:01 felixdivo

@hardbyte? 😃

felixdivo avatar Jan 27 '22 14:01 felixdivo

@cowo78, @fjburgos any objections to merging this?

zariiii9003 avatar Oct 10 '22 21:10 zariiii9003