python-can
python-can copied to clipboard
Ixxat bus state and hardware errors detection
Implemented IXXATBus.state() property. Hardware errors are detected in _recv_internal() and raise an exception.
Codecov Report
Merging #1141 (f92a056) into develop (8c4ed5f) will decrease coverage by
0.07%. The diff coverage is30.26%.
Additional details and impacted files
@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
- Coverage 65.28% 65.20% -0.08%
===========================================
Files 81 81
Lines 8832 8853 +21
===========================================
+ Hits 5766 5773 +7
- Misses 3066 3080 +14
#1119 created some conflicts
@cowo78 I can do a review once they are resolved.
Am I right in that this only adds bus.state support for can/interfaces/ixxat/canlib_vcinpl1.py and not for can/interfaces/ixxat/canlib_vcinpl2.py?
Am I right in that this only adds
bus.statesupport forcan/interfaces/ixxat/canlib_vcinpl1.pyand not forcan/interfaces/ixxat/canlib_vcinpl2.py?
Correct. As mentioned in #1119 I would suggest to postpone a refactoring / code deduplication do another PR.
I'd like this to get a single other review before merging.
@hardbyte? 😃
@cowo78, @fjburgos any objections to merging this?