kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

Published 20 hours ago • verified publisher icon haproxytech

Use Gateway api v1

Open eltorio opened this issue 1 year ago • 6 comments
trafficstars

  • reference grant still v1beta1
  • tcp route still v1alpha2

eltorio avatar Jan 31 '24 08:01 eltorio

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 01 '24 18:03 stale[bot]

hi @eltorio, if you haven't seen, CI is failing on this PR due to our policy for commit messages. Usually I would suggest squashing messages, but this is not possible since more that one author has created those.

The easiest way to figure out what is the form of commit messages can be seen if you look at the git history. Reasons how and most importantly why, can be seen here CONTRIBUTING

Unfortunately until this is resolved, we can't accept this PR.

PS. there one more open https://github.com/haproxytech/kubernetes-ingress/pull/608, almost with similar idea, but i guess this one is newer version ?

oktalz avatar Mar 11 '24 10:03 oktalz

@eltorio any chance to work on the fix for the PR ?

git001 avatar Apr 03 '24 19:04 git001

Sure I need to check but I have a lot of work! Since I made some other modifications I need to clean some things. My fork continued its own life. For example for our need it supports an annotation for enabling haproxy v2 protocol on tcproute

eltorio avatar Apr 03 '24 19:04 eltorio

Would be nice to get this over the finish line, we are also using Gateway api 1.0 and are facing this unsupported version issue. @eltorio what is still needed for this to merge ? 🙏🙏

Havnevej avatar Jul 06 '24 18:07 Havnevej