kubernetes-ingress icon indicating copy to clipboard operation
kubernetes-ingress copied to clipboard

Published 20 hours ago • verified publisher icon haproxytech

BUG/MINOR: avoid hard restarts when using a Global CRD

Open fabianonunes opened this issue 3 years ago • 0 comments

When using a global CRD, every state change triggers a hard restart on HAProxy (even a simple pod scale):

2022/08/03 16:20:49 DEBUG   global.go:81 Global config updated: [TuneOptions: <nil pointer> != models.GlobalTuneOptions]
Restart required

When synchronizing a core.haproxy.org.Global resource, the comparison with the corresponding settings in the HAProxy will always fail, because the TuneOptions attribute of an initialized models.Global is a <nil pointer> and the corresponding value returned by HAProxy is an empty models.GlobalTuneOptions.

This PR sets an empty models.GlobalTuneOptions as default value of global.TuneOptions attribute to prevent unnecessary restarts.

fabianonunes avatar Aug 03 '22 21:08 fabianonunes