haproxy-consul-connect icon indicating copy to clipboard operation
haproxy-consul-connect copied to clipboard

Published 20 hours ago • verified publisher icon haproxytech

Make logging requests configurable

Open gdubicki opened this issue 5 years ago • 5 comments
trafficstars

...not requiring the app logging level to be set to TRACE and with configurable log address - syslog socket.

I think that this fixes #45.

As this is my first contribution and one of the first golang programming attempts please do not hesitate to write me everything that I should fix before this can be merged - I will do by best to apply all the comments. :)

gdubicki avatar May 17 '20 15:05 gdubicki

@gdubicki if you don't mind, can you open a new pull request just for the 2nd commit (5aa567e4fafa3ce6f66b37bf05a9c41fc5ef28a8), we can merge the update to the test prerequisites sooner, while this discussion wraps up?

aiharos avatar May 21 '20 15:05 aiharos

@aiharos , sure please see #57 .

gdubicki avatar May 21 '20 16:05 gdubicki

I think that in the long term work on making the -help output in the README consistent with the code doesn't make sense so I have taken the liberty of removing it. Is that ok with you, @ShimmerGlass ?

gdubicki avatar Jun 03 '20 11:06 gdubicki

@gdubicki if you'd still like to incorporate the suggestions by Thorleon we could proceed with merging this.

aiharos avatar Jul 27 '20 13:07 aiharos

Will do that, @aiharos . Can you please take a look also at my other PR, https://github.com/haproxytech/haproxy-consul-connect/pull/59 ? Or perhaps there too @Thorleon can review?

gdubicki avatar Jul 27 '20 16:07 gdubicki