hyperformula icon indicating copy to clipboard operation
hyperformula copied to clipboard

Add more unit tests for dateFormats param

Open sequba opened this issue 3 years ago • 3 comments

Context

How has this been tested?

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature or improvement (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Additional language file or change to the existing one (translations)

Related issue(s):

  1. #953

Checklist:

  • [ ] My code follows the code style of this project,
  • [ ] My change requires a change to the documentation,
  • [ ] I described the modification in the CHANGELOG.md file.

sequba avatar Apr 05 '22 14:04 sequba

@sequba is this ready for review?

warpech avatar Apr 26 '22 08:04 warpech

@sequba is this ready for review?

No, it's not. It requires changes to the documentation.

sequba avatar Apr 26 '22 10:04 sequba

Performance comparison of head (28fde78626af28f9885579dc1d3a1bc448aaed7c) vs base (c43a7fe0f2120238358f4d611e81c23a11b7a06c)

                                     testName |  base |  head |  change
-----------------------------------------------------------------------
                                      Sheet A | 505.1 | 508.8 |  +0.73%
                                      Sheet B |   232 | 231.5 |  -0.22%
                                      Sheet T | 276.4 | 263.5 |  -4.67%
                                Column ranges | 682.1 | 692.3 |  +1.50%
Sheet A:  change value, add/remove row/column |    43 |    33 | -23.26%
 Sheet B: change value, add/remove row/column |   318 |   315 |  -0.94%
                   Column ranges - add column |   373 |   226 | -39.41%
                Column ranges - without batch |   650 |   829 | +27.54%
                        Column ranges - batch |   142 |   142 |   0.00%

github-actions[bot] avatar Sep 01 '22 13:09 github-actions[bot]

@sequba see my response to https://github.com/handsontable/hyperformula/pull/956#discussion_r962351522

warpech avatar Sep 05 '22 13:09 warpech

Codecov Report

Merging #956 (28fde78) into develop (2805b59) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #956      +/-   ##
===========================================
+ Coverage    95.74%   95.79%   +0.05%     
===========================================
  Files          161      161              
  Lines        14098    14094       -4     
  Branches      2977     2976       -1     
===========================================
+ Hits         13498    13502       +4     
+ Misses         584      576       -8     
  Partials        16       16              
Impacted Files Coverage Δ
src/Config.ts 98.00% <ø> (ø)
src/DateTimeHelper.ts 95.65% <ø> (ø)
src/DateTimeDefault.ts 93.75% <100.00%> (-0.22%) :arrow_down:
src/format/format.ts 99.30% <100.00%> (+5.55%) :arrow_up:

codecov[bot] avatar Sep 06 '22 14:09 codecov[bot]