Halide icon indicating copy to clipboard operation
Halide copied to clipboard

[Hexagon] Profiling changes for abadams/per_instance_profiling

Open aankit-quic opened this issue 1 year ago • 3 comments

I still see a crash on device when offloading, the culprit being IR like this:

...
let profiler_shared_sampling_token = (void *)alloca(4)
halide_profiler_init_sampling_token(profiler_shared_sampling_token, 0)
...
<Hexagon> for (output) {
    halide_profiler_acquire_sampling_token(profiler_shared_sampling_token, profiler_local_sampling_token) // profiler_shared_sampling_token is not a valid read address here
}

aankit-quic avatar Apr 11 '24 06:04 aankit-quic

Oh yeah, that sampling token didn't account for crossing a host-device boundaries inside a parallel loop. Hrm.

abadams avatar Apr 11 '24 17:04 abadams

What's the status on this PR?

steven-johnson avatar Apr 30 '24 16:04 steven-johnson

I believe it's stalled on me

abadams avatar Apr 30 '24 17:04 abadams