Halide icon indicating copy to clipboard operation
Halide copied to clipboard

Add missing std::forward calls

Open steven-johnson opened this issue 1 year ago • 2 comments

Found by enabling cppcoreguidelines-missing-std-forward (https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/missing-std-forward.html) -- that specific check isn't ready to be enabled for other reasons (it changes the behavior of other checks in ways that are painful) but doing this cleanup seems modestly worthwhile.

steven-johnson avatar Jan 26 '24 23:01 steven-johnson

Are you up for moving the small style fixes into another PR? It should be trivial to land and makes this one smaller. Optionally, update the description to explain the other changes.

zvookin avatar Feb 07 '24 18:02 zvookin

Are you up for moving the small style fixes into another PR? It should be trivial to land and makes this one smaller. Optionally, update the description to explain the other changes.

Yeah, looks like this has a lot of cruft in it that I didn't expect. Converting to draft for now.

steven-johnson avatar Feb 07 '24 18:02 steven-johnson