Halide icon indicating copy to clipboard operation
Halide copied to clipboard

Add string names to all Vars so pseudo-code output is more human-readable.

Open kaushik1618 opened this issue 4 years ago • 5 comments

This change makes the pseudo-code snippets in https://halide-lang.org/tutorials/tutorial_lesson_05_scheduling_1.html match what you get from actually compiling and executing the lesson_05_scheduling_1.cpp source code locally.

kaushik1618 avatar May 14 '21 23:05 kaushik1618

Ping, is there something I need to do to make this easier to review/approve?

kaushik1618 avatar Jun 12 '21 21:06 kaushik1618

The pseudocode snippets are supposed to match automatically. Something is going wrong with debugging symbols if they're not. My preferred fix is to figure out what went wrong with those, rather than adding explicit strings.

abadams avatar Jun 13 '21 01:06 abadams

@abadams @steven-johnson . I can see three ways to go here. First, just merge it. Second, decide the tutorials do not have the names because it makes their source clearer to read. In that event we'd recommend using the introspection support to get better names when needed. Third, modify all tutorials accordingly.

zvookin avatar Jun 13 '21 02:06 zvookin

I second @zvookin 's thoughts on this, there is a lot of educational value in having the tutorial output snippets match actual outputs. I agree that the right fix is to get to the root of the problem but I don't know when that fix will land.

kaushik1618 avatar Jun 17 '21 17:06 kaushik1618

Is this PR still active? Should it be closed?

steven-johnson avatar Nov 15 '21 19:11 steven-johnson