Halide icon indicating copy to clipboard operation
Halide copied to clipboard

Fix symbol names used for outputting schedules into valid C++ source variable names

Open derek-inteon opened this issue 4 years ago • 4 comments

Since Funcs and other classes can have user defined names, the resulting strings may be invalid C++ when used directly for variable names and identifiers during the source code generation for schedules.

This PR adds a 'conform_name' around all variable names being outputted to replace invalid characters with an underscore, to make sure only valid C++ identifiers are outputted for the schedule source.

derek-inteon avatar Feb 08 '21 20:02 derek-inteon

Where does this PR stand?

steven-johnson avatar Feb 17 '21 18:02 steven-johnson

Monday Morning Review ping: Where does this PR stand?

steven-johnson avatar Feb 22 '21 18:02 steven-johnson

Is this PR still active? If not, it will be closed.

steven-johnson avatar Apr 08 '21 17:04 steven-johnson

Is this PR still active?

steven-johnson avatar Apr 27 '21 17:04 steven-johnson