ggmosaic
ggmosaic copied to clipboard
Correct deprecation error related to argument `trans`
The use of ggplot2::continuous_scale() previously used the trans = ... argument. This has been deprecated and now the proper argument should be transform = .... This PR makes that change in two different locations and updates the documentation / DESCRIPTION, as done automatically by devtools::document().
Thanks @ian-curtis!
First, @ian-curtis, thanks for taking the initiative (I hope this and similar PR will be merged soon).
I want one thing to be clarified.
It seems that trans was deprecated in 3.5.0:
2: The
transargument ofcontinuous_scale()is deprecated as of ggplot2 3.5.0. ℹ Please use thetransformargument instead.
But when was it transformation introduced?
See comment https://github.com/haleyjeppson/ggmosaic/pull/73/files#r1770969445
The current name of PR sounds like an issue name. @ian-curtis could you, please, rename it to "Fix error related to deprecated trans", "Fix deprecated trans" or similar? The name should reflect the solution.
Related issue:
- #71
I adjusted the title of the PR to reflect its purpose.
My error message does also note that the trans argument was deprecated as of ggplot2 3.5.0. I apologize for missing that before. It is likely that ggmosaic would need to increase the minimum ggplot2 requirement to 3.5.0 otherwise I have a feeling these conflicts are going to keep coming up. I am happy to add a commit doing this but I recognize that increasing minimum package requirements can come at a cost for package developers so I will hold off for now.
I also get the error mentioned in #71 regarding scale_name. Has this issue already been fixed? Based on my fork I made of this repo the other day, I cannot find any instances of the scale_name argument being used in this package directly.