AppAuthWebView-Android icon indicating copy to clipboard operation
AppAuthWebView-Android copied to clipboard

AuthorizationService is not disposed

Open itaybia opened this issue 7 years ago • 2 comments

the AuthorizationService created inside AppAuthWebView should be disposed when not used anymore otherwise it creates a leak. also, the service creates a binding to a CustomTabManager which may be problematic (and is also something you wished not to use in the first place, but use the web view instead). i think the AppAuthConfiguration should be set with a browser matcher that will always return false.

itaybia avatar May 23 '18 09:05 itaybia

I am really busy at the moment, i can't edit this library soon, i will be grateful if you fix these problems and send me PR.

hadiidbouk avatar Jun 29 '18 07:06 hadiidbouk

For the second part I think this could work:

AppAuthConfiguration appAuthConfig = new AppAuthConfiguration.Builder()
.setBrowserMatcher(descriptor -> false)
.build();

ghost avatar Aug 11 '19 08:08 ghost