Deep-Live-Cam icon indicating copy to clipboard operation
Deep-Live-Cam copied to clipboard

Update README.md

Open david-dong828 opened this issue 1 year ago • 2 comments

See Issue (Issue #162)

updated the download link of inswapper_128_fp16.onnx file

Summary by Sourcery

Update the README.md to change the download link for the inswapper_128_fp16.onnx file.

Documentation:

  • Updated the download link for the inswapper_128_fp16.onnx file in the README.md.

david-dong828 avatar Aug 11 '24 19:08 david-dong828

Reviewer's Guide by Sourcery

This pull request updates the README.md file to change the download link for the inswapper_128_fp16.onnx model file. The link has been updated from a Hugging Face URL to a GitHub URL.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot] avatar Aug 11 '24 19:08 sourcery-ai[bot]

Hey @david-dong828 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you please provide more context about why this link change is necessary? Is the new source more official or maintained? This information would be helpful for understanding and documenting the change.

Here's what I looked at during the review Sourcery is free for open source - if you like our reviews please consider sharing them ✨ Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Hi,

please take https://github.com/hacksider/Deep-Live-Cam/issues/162 as a reference.

The new file solved the 'NO face but only black square' issue.

Thanks

david-dong828 avatar Aug 11 '24 19:08 david-dong828