Deep-Live-Cam icon indicating copy to clipboard operation
Deep-Live-Cam copied to clipboard

Fix/requirements and runtime

Open Repulzer opened this issue 6 months ago • 2 comments

Summary by Sourcery

Refine dependency specifications to ensure GPU-enabled installations and fix Unicode image writing logic

Bug Fixes:

  • Ensure imwrite_unicode prefixes file extensions correctly and only writes the file when encoding succeeds

Build:

  • Add pygrabber and update torch/torchvision requirements for CUDA support on Windows/Linux with CPU fallback on macOS
  • Unify ONNX Runtime to a single GPU-accelerated onnxruntime-gpu dependency
  • Include tensorflow for non-macOS platforms

Repulzer avatar May 12 '25 16:05 Repulzer

Reviewer's Guide

Refactored requirements.txt to streamline and unify platform-specific dependencies (PyTorch, ONNX Runtime, TensorFlow, etc.) and enhanced the imwrite_unicode utility to reliably encode extensions and write data only upon successful encoding.

File-Level Changes

Change Details Files
Updated project dependencies for unified, platform-aware runtime setup
  • Added pygrabber
  • Defined torch and torchvision versions conditionally based on sys_platform
  • Replaced platform-specific ONNX Runtime packages with a single onnxruntime-gpu
  • Introduced tensorflow dependency for non-macOS environments
requirements.txt
Improved imwrite_unicode to handle extension formatting and encoding success
  • Ensured extension string includes leading dot
  • Changed params default handling to explicitly check for None
  • Added guard to write file only if encoding result is True
modules/__init__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar May 12 '25 16:05 sourcery-ai[bot]