codimd icon indicating copy to clipboard operation
codimd copied to clipboard

No spell checking menu in Firefox

Open panigrc opened this issue 7 years ago • 4 comments

Unfortunately I made the mistake posting this issue to the Enterprise Hackmd Version. https://github.com/hackmdio/hackmd-io-issues/issues/19

Firefox: 60.0.2 (64bit) System: Xubuntu 14.04

With spell checker enabled in Hackmd when right clicking on a wrong word, Firefox doesn't display the spell checking menu (Choose language and word suggestions).

hackmd_no_firefox_spellcheck

panigrc avatar Jun 21 '18 22:06 panigrc

Well, unfortunately this is not a bug but a missing feature.

HackMD implements spell-checking using this library which only checks for what is wrong. It doesn't offer suggestions and doesn't use the browsers spell-checker.

So it's normal to also not have suggestions. But of course we welcome every improvement into this direction :)

SISheogorath avatar Jun 22 '18 10:06 SISheogorath

Please see also #150 Since CodeMirror is not using input or textarea to show text, it does not work well with native browser actions like spell-check or word suggestions.

It possible if we implement a custom context menu for this, but I don't know if this is an over-killed.

jackycute avatar Jun 22 '18 10:06 jackycute

There is this example: https://plnkr.co/edit/0y1wCHXx3k3mZaHFOpHT?p=preview

We can may have a look and decide if we want to go for that or not.

To be honest, I don't like custom context menus, but at least the spell-checker would make more sense then ^^

SISheogorath avatar Jun 22 '18 10:06 SISheogorath

If a context menu might not be the best choice, how about having a place to add local words to a whitelist?

MarcelWaldvogel avatar May 12 '21 12:05 MarcelWaldvogel