website icon indicating copy to clipboard operation
website copied to clipboard

Bug on code of conduct

Open Aveline-art opened this issue 3 years ago • 5 comments
trafficstars

Overview

This is a bug that I have found.

When I was searching through Google for our code of conduct, it gave me a link to an incomplete page. Please look at the resources for more information.

Note: Might overlap with #110. I'm not sure 😔

Action Items

  • [ ] Explore ways to keep Broken code of conduct page from displaying when the site is googled.
    • [ ] Try the following possible approach: Jekyll's configuration accepts file exclusions, which prevents the file from being considered when site is built.
  • [ ] Make sure the fix/changes do not affect other parts of the website.

Resources/Instructions

Google search

Broken code of conduct page

  • Please read through the commens for additional information and links

Aveline-art avatar Dec 27 '21 05:12 Aveline-art

Hi @Aveline-art.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing: Size, Role, Feature

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards. To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

github-actions[bot] avatar Dec 27 '21 05:12 github-actions[bot]

I realized why this page is in our main dir: https://github.com/hackforla/website/blob/gh-pages/CODEOFCONDUCT.md Its part of GitHub's health files https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file

So the question is how do we keep it from displaying when the site is googled.

ExperimentsInHonesty avatar Jan 05 '22 21:01 ExperimentsInHonesty

@ExperimentsInHonesty Jekyll's configuration accepts file exclusions, which prevents the file from being considered when site is built. Not sure if this works, but worth a shot?

Aveline-art avatar Jan 23 '22 19:01 Aveline-art

Hi @michaelmagen, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Oct 13 '22 17:10 github-actions[bot]

Availability: 4 hours ETA: 10/16/22

michaelmagen avatar Oct 13 '22 17:10 michaelmagen

@michaelmagen

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 18, 2022 at 12:33 AM PST.

github-actions[bot] avatar Oct 21 '22 07:10 github-actions[bot]

Hi @michaelmagen, So we went ahead last night and made the edit you suggested. Unfortunately now google search links directly to the CODEOFCONDUCT.md instead of the html. We're going to role it back but @jdingeman recommended looking at https://github.com/jbranchaud/til/blob/master/html/prevent-search-engines-from-indexing-a-page.md

blulady avatar Oct 21 '22 14:10 blulady

Progress: Need to check with others about testing of new approach Blockers: Initial approach did not work, attempting new approach to solve problem Availability: 4 hours ETA: 10/25/22

michaelmagen avatar Oct 24 '22 23:10 michaelmagen

Progress: Need to check with others about testing of new approach Blockers: Initial approach did not work, attempting new approach to solve problem Availability: 4 hours ETA: 10/25/22

Thanks for updating. I'll remove the two-weeks inactive label but feel free to do it yourself.

blulady avatar Oct 25 '22 01:10 blulady