website icon indicating copy to clipboard operation
website copied to clipboard

Google Apps Script: Migrate Wins Data - Delete AF file

Open Aveline-art opened this issue 4 years ago • 8 comments

Dependency

  • #2147
  • #4134
  • #3641

Overview

As a developer, to turn the wins card into a reusable component, we must first be able to generate a wins-data.json file of a more specific format. This issue is part of a series that aims to migrate us to the more specific format.

Action Items

  • [ ] Read the resources/instructions below to understand your task.
  • [ ] Delete the AF version of our file from our codebase.
  • [ ] Check and make sure that all pages in the website still appears as before this change.

Resources/Instructions

wins-page

Currently we have two json files for wins: _wins-data.json and wins-data.json. The former will henceforth be called KVF (for key-value file) and AF (for array file). AF is generated daily from a script on google while KVF appears to be an older, dysfunc version. The format in the KVF version, however, is much friendlier to formatting in liquid syntax. Therefore, we need to incrementally port our codebase to use the KVF version of the data and remove the AF version we currently use. This will be done in multiple steps:

  1. Have the apps script generate both AF and KVF version.
  2. Migrate all uses of AF to KVF.
  3. Have the apps script stop generating the AF version.
  4. Delete the AF version from our repo since it is now unused.

For this issue, we are doing step 4.

Aveline-art avatar Aug 20 '21 17:08 Aveline-art

Hi @steven-positive-tran, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar Jan 28 '23 09:01 github-actions[bot]

Availability: "How much time will you have this week to work on this issue?"

  • Avaialble after 6 anyday, if needed before maybe we can schedule somethihg.

ETA: "When do you expect this issue to be completed?"

  • I will try to get this done on Sunday

steven-positive-tran avatar Jan 28 '23 09:01 steven-positive-tran

Moved this back to the Ice Box since its dependency has not been satisfied.

jdingeman avatar Feb 01 '23 02:02 jdingeman

Hi @Abdessittir, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:- i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?) ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

github-actions[bot] avatar May 25 '23 07:05 github-actions[bot]

i. Availability: after 2 days ii. Next Monday

AHP15 avatar May 25 '23 08:05 AHP15

Hi @Abdessittir this issue is in the "Ice Box" column of the Project Board and is not ready for assignment. Please select issue only from the Prioritized Backlog column.

roslynwythe avatar May 25 '23 23:05 roslynwythe

Hi @roslynwythe, thanks for letting me know, but I didn't find any second issue in the Prioritized Backlog column, should I wait until one is added?

AHP15 avatar May 26 '23 08:05 AHP15

Hi @roslynwythe, thanks for letting me know, but I didn't find any second issue in the Prioritized Backlog column, should I wait until one is added?

Hi @Abdessittir - instead of a second good issue, please take another first good issue. Thanks

roslynwythe avatar May 26 '23 16:05 roslynwythe