hcb icon indicating copy to clipboard operation
hcb copied to clipboard

Published 20 hours ago • verified publisher icon hackclub

speed up stripe authorizations! 🚀

Open 24c02 opened this issue 7 months ago • 1 comments

hitting the DB to calculate balances is slow & handling authorization requests is a critical path – if a user's card declines because our webhook timed out, that's entirely preventable bad UX. besides, we already approve most transactions!

24c02 avatar Apr 01 '25 20:04 24c02

this PR scares me

sampoder avatar Apr 01 '25 20:04 sampoder

this lgtm

RhysMP avatar Apr 02 '25 02:04 RhysMP

no way lmfao

cytronicoder avatar Apr 05 '25 01:04 cytronicoder

Tests pass, LGTM

pmnlla avatar Apr 06 '25 20:04 pmnlla

the test suite only failed because CI is broken, the spec for this functionality seems to pass

24c02 avatar Apr 06 '25 20:04 24c02

Personally I think we should remove tests from the codebase and ask ChatGPT to do a vibe code review

SkyfallWasTaken avatar Apr 06 '25 20:04 SkyfallWasTaken

isn’t that what copilot is for?

24c02 avatar Apr 06 '25 20:04 24c02

Good point! In fact I think we should use Copilot to vibecode a whole new version of HCB! After all, E = mc^2 + AI

SkyfallWasTaken avatar Apr 06 '25 20:04 SkyfallWasTaken

translation: copilot said "no vulns LGTM"

i think my only complaint is that there isn't a fully featured version of Doom running the bank in the backend, but I'll suck it up

pmnlla avatar Apr 06 '25 22:04 pmnlla

sorry :( it's still too slow

sampoder avatar Apr 08 '25 19:04 sampoder

that's it I've had enough with this platform image

SkyfallWasTaken avatar Apr 08 '25 19:04 SkyfallWasTaken

reopen this RIGHT NOW.

pmnlla avatar Apr 18 '25 00:04 pmnlla