Moodle 3.9 unit test failures.

[danmarsden]

Moodle core unit tests fail when installing the mod_hvp plugin.

The fix seems to be in the upstream h5p class already: https://github.com/h5p/h5p-php-library/pull/68

The fix for the h5p plugin just needs a new release with that version of the upstream h5p class.

-- unit test failures below to help others googling the same issue: --

1. contenttype_h5p_contenttype_plugin_testcase::test_delete_content Error: Call to a member function get_content() on boolean

/var/www/html/h5p/classes/file_storage.php:670 /var/www/html/h5p/classes/file_storage.php:236 /var/www/html/mod/hvp/library/h5p.classes.php:2446 /var/www/html/h5p/classes/player.php:408 /var/www/html/h5p/classes/player.php:362 /var/www/html/h5p/classes/player.php:220 /var/www/html/contentbank/contenttype/h5p/tests/contenttype_h5p_test.php:61 /var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run: vendor/bin/phpunit --colors "contenttype_h5p_contenttype_plugin_testcase" contentbank/contenttype/h5p/tests/contenttype_h5p_test.php

2. contenttype_h5p_contenttype_plugin_testcase::test_get_icon Error: Call to a member function get_content() on boolean

/var/www/html/h5p/classes/file_storage.php:670 /var/www/html/h5p/classes/file_storage.php:236 /var/www/html/mod/hvp/library/h5p.classes.php:2446 /var/www/html/h5p/classes/player.php:408 /var/www/html/h5p/classes/player.php:362 /var/www/html/h5p/classes/player.php:220 /var/www/html/contentbank/contenttype/h5p/tests/contenttype_h5p_test.php:142 /var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run: vendor/bin/phpunit --colors "contenttype_h5p_contenttype_plugin_testcase" contentbank/contenttype/h5p/tests/contenttype_h5p_test.php

[hdagheda]

Also vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

2. provider_testcase::test_userdata_provider_implements_userlist with data set "mod_hvp" ('mod_hvp', 'mod_hvp\privacy\provider') Failed asserting that false is true.

/siteroot/privacy/tests/provider_test.php:212 /siteroot/lib/phpunit/classes/advanced_testcase.php:80

[aspark21]

Looks like this was fixed in this plugin's stable branch on 4th August

https://github.com/h5p/moodle-mod_hvp/commit/3f721533c21abd8b61d03a961ad131043e6c741e

[XTRage]

Also vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

1. provider_testcase::test_userdata_provider_implements_userlist with data set "mod_hvp" ('mod_hvp', 'mod_hvp\privacy\provider') Failed asserting that false is true.

/siteroot/privacy/tests/provider_test.php:212 /siteroot/lib/phpunit/classes/advanced_testcase.php:80

This one still exists.