imaginary icon indicating copy to clipboard operation
imaginary copied to clipboard

Added support for saving as AVIF

Open ItalyPaleAle opened this issue 3 years ago • 4 comments

Added support for converting images to AVIF. This adds avif as a supported type.

Some notes:

  1. Generating AVIF images can be very slow, especially for large ones. I mean, it can take multiple seconds or minutes-but the results are great.
  2. There's currently a bug in libheif that makes the app crash when saving images to HEIF if running on ARM64: https://github.com/strukturag/libheif/issues/608

If the two things above are an issue, I can make AVIF support optional by adding a flag.

(For some reason, the formatter on my machine re-formatted some code blocks and caused a lot of lines to be changed and removed some whitespace... if that's not desired, I can try again and see how I can un-do the formatting changes)

ItalyPaleAle avatar Feb 20 '22 22:02 ItalyPaleAle

+1

rluisr avatar Jun 24 '23 17:06 rluisr

AVIF support is warmly welcome, and I badly need it.

Hope this PR can be taken soon...

suntong avatar Nov 28 '23 03:11 suntong

@h2non Sorry for the ping, but did you maybe overlook this or so, as this has been open for almost 2 years now with no feedback (and I've seen you still merge new PRs within a few weeks or so). This would be needed for good AVIF support for Nextcloud...

cromefire avatar Dec 23 '23 20:12 cromefire

I couldn't wait so I merge it myself and together with an bunch of other PRs, which is now 11 commits ahead of h2non/imaginary:master -- https://github.com/suntong/imaginary/tree/dev

suntong avatar Dec 24 '23 02:12 suntong