gwt-eclipse-plugin icon indicating copy to clipboard operation
gwt-eclipse-plugin copied to clipboard

Published 20 hours ago • verified publisher icon gwt-plugins

Updated Guava and javax.servlet dependencies

Open keinhaar opened this issue 2 years ago • 1 comments

  • Removed the included 2 guava libraries and replaced them by an dependency to the bundle com.google.guava which is included in eclipse anyway.
  • replaced the javax.servlet dependency by jakarta.servlet-api, which is included since 2021-06.

keinhaar avatar Dec 09 '22 17:12 keinhaar

Hi @keinhaar, this PR seems interesting, but I wonder how safe is using Eclipse's guava. I wonder if we introduce a dependency between the version we need, and the version eclipse distributes. Moreover, we're "exporting" guava. What does it mean?

About servlet APIs... the proposed fix is already in main, isn't it?

So... at the very least the PR must be re-done (best thing to do in my opinion is back merging main branch to your branch and make a manual merge)

Let me know!

protoism avatar Feb 15 '23 06:02 protoism