RuntimeAudioImporter icon indicating copy to clipboard operation
RuntimeAudioImporter copied to clipboard

Published 20 hours ago • verified publisher icon gtreshchev

Added direct transcode for RAW audio

Open lkoren21 opened this issue 1 year ago • 2 comments

When using transcode with an intermediate format some quality was lost. Now all transcoding is done from format to format without the need for an intermediate format.

lkoren21 avatar Jun 26 '24 12:06 lkoren21

That's a great approach, thank you for your contribution! The only thing is that having separate declarations and definitions of templated functions may lead to code generation and linker issues on some compilers, so it would be better to implement this function in a header file for the best cross-platform results. Can you please move the full definition of TranscodeTo to the RuntimeAudioTranscoder.h file and include #include "Codecs/RAW_RuntimeCodec.h" at the top of the file?

gtreshchev avatar Jun 28 '24 20:06 gtreshchev

Thank you. I'll do it ASAP.

lkoren21 avatar Jul 02 '24 18:07 lkoren21

I've made the necessary changes. You can merge if everything is all right.

lkoren21 avatar Jul 03 '24 11:07 lkoren21