python-colormath icon indicating copy to clipboard operation
python-colormath copied to clipboard

Add RGB_to_YIQ and YIQ_to_RGB

Open Mattwmaster58 opened this issue 5 years ago • 5 comments

Inspired by scikit's implementation.

Mattwmaster58 avatar May 06 '20 23:05 Mattwmaster58

Any chance we could get this merged/reviewed?

Mattwmaster58 avatar Jan 28 '22 03:01 Mattwmaster58

Hi @Mattwmaster58,

Any reason for not using Scikit-Image conversion? It is already there, vectorised and unit tested.

KelSolaar avatar Jan 28 '22 04:01 KelSolaar

Sometimes one may prefer a "lighter" library.

Mattwmaster58 avatar Jan 28 '22 04:01 Mattwmaster58

That makes sense but then adding new features does not contribute to keep it lightweight. What is the use case for YUV/YIQ?

KelSolaar avatar Jan 28 '22 04:01 KelSolaar

Understandable. The line between 'lightweight' is sometimes hard to draw. I believe my use case here was a small image comparison library, but I'm not actively working with it at the moment. If you don't want to add this for lightweight/testing concerns I can understand

Mattwmaster58 avatar Jan 28 '22 05:01 Mattwmaster58