markor icon indicating copy to clipboard operation
markor copied to clipboard

Published 20 hours ago • verified publisher icon gsantner

Bug Report: Delayed Appearance of Newly Created Folders

Open XYIheng opened this issue 1 year ago • 11 comments
trafficstars

⚠️ This issue respects the following points: ⚠️

  • [X] This is a bug. Not a question or feature request.
  • [X] The topic is not already reported at Issues. (I've searched it).
  • [X] Markor is up to date. See Releases for the latest version. Updates are available from F-Droid and GitHub.
  • [X] The bug is still present in the latest development version (git master). (Please download and try the test version of Markor, named Marder. Don't worry; Markor and Marder appear as completely separate applications. You can install both side-by-side, and Markor settings are not touched. In case the issue is resolved there, you don't need to create a bug report. The change will be part of the next Markor update.)

Description

In the markor, when creating a new folder, the new folder does not appear immediately. The delayed appearance of the newly created folder causes confusion and disrupts the expected user experience.

Steps to reproduce

  1. click FAB
  2. rotate device
  3. enter the folder name
  4. click Folder
  5. see error: the created folder doesn't appear, and you need to refresh the app to let the folder appear

https://github.com/gsantner/markor/assets/31406320/1e2c8617-e084-4b71-945e-841e6f7d1198

Information

Android version: Android 10 Device: pixel2 and pixel 7 App Version: 2.11.1

Source

F-Droid

Format / File type

Not specific

Additional info / Log

-

XYIheng avatar Mar 27 '24 12:03 XYIheng

please download test builds from https://github.com/gsantner/markor/actions?query=branch%3Amaster+actor%3Agsantner if you didnt already - click the latest build and you can find a android-apk button to download.

Is it better in Marder?

gsantner avatar Mar 27 '24 17:03 gsantner

@gsantner Hi, I just download the latest build apk from your link and find the bug still exists

XYIheng avatar Mar 27 '24 18:03 XYIheng

In Marder? (If you check Markor you dont use the version from that apk)

gsantner avatar Mar 27 '24 18:03 gsantner

@gsantner Yes, in Marder. image

XYIheng avatar Mar 28 '24 12:03 XYIheng

https://github.com/gsantner/markor/assets/31406320/95a0a5e2-5c90-4f30-9a8c-fa258c696568

Also not work when try to create new files

XYIheng avatar Mar 28 '24 15:03 XYIheng

Humbly said, I can not reproduce on release nor testversion. New stuff shows up after accepting.

gsantner avatar Mar 28 '24 19:03 gsantner

Humbly said, I can not reproduce on release nor testversion. New stuff shows up after accepting.

Hi, I downloaded Marder from this link https://github.com/gsantner/markor/actions/runs/8483832311 And tested it on my real device: Xiaomi 10s, MIUI14.0.6. The bug still exists

XYIheng avatar Apr 03 '24 11:04 XYIheng

I can also reproduce this bug. apk version (the one that @XYIheng mentioned above): https://github.com/gsantner/markor/actions/runs/8483832311

HUAWEI HONER Android: 12 OS: MagicOS 7.0 Model: AGT-AN00

XixianLiang avatar Apr 03 '24 11:04 XixianLiang

Feel free to fix the issue and create a merge request. Thanks!

gsantner avatar Apr 03 '24 19:04 gsantner

I have traced this bug.

We pass a callback into the NewFileDialog to be triggered when the dialog completes. Upon rotation, the dialog is recreated and the callback is invalidated.

We need to either preserve the callback (difficult) or change how we trigger whatever we want to trigger after the dialog is complete.

harshad1 avatar Apr 21 '24 03:04 harshad1

Ok, the solution was simple. I have it included here - https://github.com/gsantner/markor/pull/2275/files

harshad1 avatar Apr 21 '24 04:04 harshad1

closed by #2277

gsantner avatar May 20 '24 20:05 gsantner