cloud-nuke icon indicating copy to clipboard operation
cloud-nuke copied to clipboard

Migrate to aws sdk v2 part 1

Open wakeful opened this issue 1 year ago • 1 comments

Description

port the below resources to AWS SDKv2 (part of work for #770

  • APIGWv1
  • APIGWv2
  • ASG
  • access_analyzer
  • acm
  • acmpca
  • ami
  • appRunner
  • backupvault
  • cloudTrail
  • cloudWatchalarm
  • cloudWatchdashboard
  • cloudWatchlogGroup
  • codeDeployApplication
  • configrecorder
  • configservice
  • dataSynclocation
  • dataSynctask
  • dynamodb

TODOs

Read the Gruntwork contribution guidelines.

  • [x] Update the docs.
  • [x] Run the relevant tests successfully, including pre-commit checks.
  • [x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • [x] Include release notes. If this PR is backward incompatible, include a migration guide.
  • [ ] Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated APIGWv1, APIGWv2, ASG, access_analyzer, acm, acmpca, ami, appRunner, backupvault, cloudTrail, cloudWatchalarm, cloudWatchdashboard, cloudWatchlogGroup, codeDeployApplication, configrecorder, configservice, dataSynclocation, dataSynctask, dynamodb to AWS SDK v2.

Migration Guide

n/a

wakeful avatar Oct 20 '24 11:10 wakeful

Triggered tests for this change.

james00012 avatar Oct 22 '24 23:10 james00012

rebase to remove conflicts.

wakeful avatar Oct 26 '24 20:10 wakeful

Nice. LGTM.

james00012 avatar Oct 28 '24 17:10 james00012