cloud-nuke icon indicating copy to clipboard operation
cloud-nuke copied to clipboard

Published 20 hours ago • verified publisher icon gruntwork-io

Fix tests failing

Open ina-stoyanova opened this issue 4 years ago • 2 comments

Currently a few tests on master are failing:

  • [x] TestDeleteFullIamUser (fixed by #255)
  • [x] TestListSecretsManagerSecrets (fixed by https://github.com/gruntwork-io/cloud-nuke/pull/259)
  • [x] TestTimeFilterExclusionNewlyCreatedSecret (fixed by https://github.com/gruntwork-io/cloud-nuke/pull/259)
  • [ ] TestCanNukeAllEcsClustersOlderThan24Hours

ina-stoyanova avatar Nov 03 '21 17:11 ina-stoyanova

Test TestCanNukeAllEcsClustersOlderThan24Hours seems to pass now

image

image

denis256 avatar Jan 10 '22 14:01 denis256

Hm, I'm still seeing a lot of flaky tests. Consider the test history on this branch. I re-ran the tests a bunch of times and got different failures each time:

  • TestDeleteFullIamUser
  • TestListEIPAddress
  • TestNukeTransitGatewayVpcAttachment
  • TestListSecretsManagerSecrets
  • TestCanListAllOpenSearchDomainsOlderThan24hours

So I think there's more work to be done to make these tests resilient.

brikis98 avatar Jan 12 '22 12:01 brikis98

All the tests have been fixed and refactored. Closing this issue.

james00012 avatar Oct 27 '23 20:10 james00012