grunt dosen't show colour for tasks

[paladox]

Hi I'm testing using grunt 1.0.1 but in grunt-contrib-jshint and grunt-jscs and grunt-jsonlint they showed colour in 0.4.5 but in 1.0.1 they doint show colour any more.

See https://integration.wikimedia.org/ci/job/mediawiki-core-npm-node-4.3/598/console please

And this is what it should look like https://integration.wikimedia.org/ci/job/mediawiki-core-npm-node-4.3/593/console

It also doesn't show it underlined but works in grunt 0.4.5.

[shama]

Thanks for the report! Could you help us debug this issue? I'm guessing the escape sequences have changed since upgrading colors from 0.6.2 to 1.1.2 in grunt-legacy-log?

[paladox]

@shama how do I debug. And what do I look for.

Please.

[paladox]

@shama maybe because for this https://github.com/Marak/colors.js/commit/dfb15b55382772ba4fd34fc21922a2d83e9d34d3

And seems to split the colours to so ones for text and the other for background.

[paladox]

I'm not sure if I should also file the task with grunt-contrib-jshint but it seems to be happening to all packages.

[paladox]

Im not sure which one is better colors or chalk which grunt-contrib-jshint uses.

https://github.com/gruntjs/grunt-contrib-jshint/blob/master/package.json#L19

https://www.npmjs.com/package/chalk

[paladox]

@shama maybe.

[shama]

@paladox Thanks for looking into this. Would you be able to print some green text using [email protected] vs [email protected]? If that is the problem we could revert back to that version to fix.

I'd like to use chalk eventually but would like to throw a deprecation message to everyone using the prototype extensions that come along with colors first.

[paladox]

@shama I think I may have found out why. You carn't require colours as you do in https://github.com/gruntjs/grunt-legacy-log/blob/master/index.js#L18

Instead changing it to

var colors = require('colors/lib/index');

I have't tested it with grunt, since I doint know but doing it on a test file and only adding colors in there wont work I have to do colors/lib/index which worked.

[paladox]

@shama ive submitted the patch here https://github.com/gruntjs/grunt-legacy-log/pull/16 that hopefully will fix the problem.

[paladox]

@shama I tracked where the problem is coming from, ive uploaded the fix here https://github.com/Marak/colors.js/pull/157 but is unlikely to be merged since there hasen't been any commits since September laster year.

Ive created a pull here https://github.com/gruntjs/grunt-legacy-log/pull/20 for grunt-legacy-log that includes https://github.com/Marak/colors.js/pull/157

Ive tested using no color config and specifying --no-color which works.