TinyIoC icon indicating copy to clipboard operation
TinyIoC copied to clipboard

Published 20 hours ago • verified publisher icon grumpydev

TinyIoC: Fix missing XML documentation

Open adbre opened this issue 11 years ago • 5 comments
trafficstars

I recently did some work in a project where the assembly including TinyIoC built XML documentation, and they had enabled 'Treat warning as errors', so TinyIoC caused compile errors out of the box. This PR fixes this.

adbre avatar May 31 '14 05:05 adbre

A better fix is to not include the raw CS file, but rather a built DLL in the nuget package.

see issue #54

ghostsquad avatar Jun 02 '14 14:06 ghostsquad

@ghostsquad the whole point of tinyioc is to not do that.. so no, that's not a "better fix"

grumpydev avatar Jun 02 '14 14:06 grumpydev

I agree with @grumpydev, in my case TinyIoC must be included as a cs-file, and made internal. Exactly the point why TinyIoC is distributed as it is.

adbre avatar Jun 02 '14 17:06 adbre

Any plans on getting this merged? :)

As a workaround I'm adding some pragma statements to the file in the project I'm currently working on.

#pragma warning disable 1574, 1591, 1711, 1712

thomaswurtz avatar Mar 29 '16 13:03 thomaswurtz

Can you fix the merge conflicts and we'll accept this pr with the documentation changes.

niemyjski avatar Aug 18 '18 13:08 niemyjski