grpc-web Fix JS Generator Identifier when name is camel case

Fix JS Generator Identifier when name is camel case

Open nnnnoel opened this issue 3 years ago • 2 comments

This PR fixes JS Generator when field name is camel case protocolbuffers/protobuf-javascript#17

protobuf PR: https://github.com/protocolbuffers/protobuf-javascript/pull/3

example

message Message {
    int32 someCamelCaseMessage = 1;
}

Apr 22 '22 05:04 nnnnoel

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: nnnnoel / name: Noel Kim (김민혁) (cb36308401a73c24d22d80dc4176d01de72e3a2d, 111646382b9c355ca22d817432054da469afb44a, 28f1ea7bf9939d22e8cbfe5d948f48b0eb38127a)

Apr 22 '22 05:04 linux-foundation-easycla[bot]

Thank you so much for taking the initiative to fix this both in protobuf and here!

I'll probably take a look after the protobuf change is approved! :) Please ping the thread here once it is. Thanks! :)

Apr 25 '22 22:04 sampajano

I don't know why protobuf PR has closed. but I also close this PR because of https://github.com/protocolbuffers/protobuf-javascript/pull/3

Oct 20 '22 09:10 nnnnoel

Ahh not sure about protobuf.. Thanks for the update anyways tho..

Oct 20 '22 22:10 sampajano