grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

internal/grpcutil: Encode timeout headers concisely

Open mwilliams-sfo opened this issue 1 week ago • 2 comments

30 seconds, for example, should encode as "30S" not "30000000u". Both conform to the specification, but the former uses fewer bits and is more readable in a dump.

RELEASE NOTES: n/a

mwilliams-sfo avatar Dec 10 '25 05:12 mwilliams-sfo

CLA Missing ID CLA Not Signed

  • :x: The email address for the commit (55e45b5fa2ad2a367a833f13356dd8ae3ee6e3be, 94278d06e34d68eac757105f554962ddceeffc15, d16ee407e00df5375770a33f5407f9a1ef583689) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 83.23%. Comparing base (81a00ce) to head (55e45b5). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8759      +/-   ##
==========================================
+ Coverage   83.22%   83.23%   +0.01%     
==========================================
  Files         418      418              
  Lines       32385    32386       +1     
==========================================
+ Hits        26952    26958       +6     
+ Misses       4050     4047       -3     
+ Partials     1383     1381       -2     
Files with missing lines Coverage Δ
internal/grpcutil/encode_duration.go 100.00% <100.00%> (+11.11%) :arrow_up:

... and 22 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 10 '25 05:12 codecov[bot]