grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64

Open misvivek opened this issue 1 year ago • 4 comments

Fixes #4552

RELEASE NOTES:

  • grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64

misvivek avatar Oct 17 '24 05:10 misvivek

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: misvivek (32d1ca15b5de9169d1c63a68676b066e38db3bbe, 786724dc15f0dd1f6a808fe53ba5b31ac82add74, eb85e4019eb3d6a0b7ac0a6c5ef4c396dd2681c1, 2bf22b3938e053f2db1d12d6951a1eb4a2f0a2cf, c830a6c5ea08b39517d37dea97af6992c5069ef0, 94f6a63118a49e31fce5183eaca75ed9816242d2, fad889295f4fd7c73f7900e9f3846b3f13bb2037, 5bbf7d6ac3694657797c5e0ce4c9b661e7d42b0d, 6dfb4a9559ec1754b0fbf493b2b8814c7103fea8, 8f513483d409758b97a82c8f81b441336f9caaeb, 63934e6f204cf68c22c55d649a87408e1e233b57, b1bd3b39fb1ee0fb45e3d7ad79a7fcd93a2c7a35, 56f4538a8aea919a3968c43e505c3c8295203ac1, f3afb7847b24ea5aff5aded730c1ee57e3358af3)

@misvivek please keep the description and pr title in the format as I have updated

purnesh42H avatar Oct 17 '24 06:10 purnesh42H

noted @purnesh42H

misvivek avatar Oct 17 '24 07:10 misvivek

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.98%. Comparing base (c63aeef) to head (f3afb78). Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7753      +/-   ##
==========================================
+ Coverage   81.80%   81.98%   +0.17%     
==========================================
  Files         375      377       +2     
  Lines       37978    38132     +154     
==========================================
+ Hits        31068    31262     +194     
+ Misses       5609     5564      -45     
- Partials     1301     1306       +5     
Files with missing lines Coverage Δ
rpc_util.go 79.94% <100.00%> (+0.62%) :arrow_up:

... and 33 files with indirect coverage changes

codecov[bot] avatar Oct 22 '24 06:10 codecov[bot]