grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

protoc-gen-go-grpc: add period to end of generated comment

Open infovivek2020 opened this issue 1 year ago • 16 comments

Addresses: https://github.com/grpc/grpc-go/issues/7350 RELEASE NOTES: N/A

infovivek2020 avatar Jul 04 '24 18:07 infovivek2020

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: infovivek2020 (c26c5bde37fd820c6ac74d34ee8882bb1e705a53, 6189b10d9adf0dbc139f189a7d2c78183564b3f2, f6548aac10495fee70648ae1780046ace6bdfc41, f71b71de45d6992aa9da3a85b8b520f80b5a290a, 6da400400390586deabe23720ae11d6a8b908147, 7e61a1e921a117700c51c2b848a319134cc3ef56, ed501a9d580956d026a31e9af10f29ab32a6de50, bd7f205394d98171f469503d7a531dd083750bd8, d9a3efc7476373cbf5775931a700633e92198f5c)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.55%. Comparing base (ee62e56) to head (d9a3efc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7392      +/-   ##
==========================================
+ Coverage   81.50%   81.55%   +0.05%     
==========================================
  Files         348      348              
  Lines       26752    26752              
==========================================
+ Hits        21804    21818      +14     
+ Misses       3766     3757       -9     
+ Partials     1182     1177       -5     

see 12 files with indirect coverage changes

codecov[bot] avatar Jul 04 '24 18:07 codecov[bot]

@purnesh42H previous PR #7362 do consider this one Do assign me as assignee

infovivek2020 avatar Jul 04 '24 18:07 infovivek2020

Thanks @infovivek2020. LGTM. Please take a look at some of the other submitted PRs and add RELEASE NOTES section in your PR description as part of Mergeable check

purnesh42H avatar Jul 05 '24 04:07 purnesh42H

@infovivek2020 can you comment on the issue #7350 that you have raised a PR for this so that I can assign it to you

purnesh42H avatar Jul 05 '24 04:07 purnesh42H

@infovivek2020 just a reminder to add RELEASE NOTES in the PR description so that we can go ahead and merge

purnesh42H avatar Jul 08 '24 10:07 purnesh42H

@infovivek2020 don't edit changelog.md. In your PR description, you can mention "RELEASE NOTES: N/A"

purnesh42H avatar Jul 09 '24 08:07 purnesh42H

@infovivek2020 : Could you please sign the CLA.

easwars avatar Jul 09 '24 20:07 easwars

@purnesh42H right now i am facing "HEAD is now at 0dfcf4e Merge c26c5bde37fd820c6ac74d34ee8882bb1e705a53 into daab56344e612097fd50c46c433de5d9b6013837 Error: Process completed with exit code 1."

infovivek2020 avatar Jul 10 '24 06:07 infovivek2020

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

purnesh42H avatar Jul 10 '24 06:07 purnesh42H

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

This PR affects codegen, so it should regenerate everything regardless.

dfawley avatar Jul 10 '24 16:07 dfawley

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

Not very important, but relevant for this PR.

This https://github.com/grpc/grpc-go/pull/7351 introduce support for editions. However our regenerate scripts is broken complaining something like this:

protoc-gen-go: invalid FileDescriptorProto "examples/route_guide/routeguide/route_guide.proto": proto: invalid syntax: "editions"

I'm investigating this. Let me see if I get some time to fix this today.

arvindbr8 avatar Jul 10 '24 16:07 arvindbr8

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

This PR affects codegen, so it should regenerate everything regardless.

yeah I mean the protos are regenerated but do we have to regenerate again after Arvind's fix?

purnesh42H avatar Jul 11 '24 06:07 purnesh42H

@infovivek2020 can you pull and rebase your branch on latest upstream and then run ./scripts/regenerate.sh again?

purnesh42H avatar Jul 11 '24 06:07 purnesh42H

@infovivek2020 looks like you got unwanted files in your push. Can you try following

  1. git checkout master
  2. git pull upstream master
  3. git rebase upstream/master
  4. git checkout "your branch"
  5. git rebase master
  6. git push --force

purnesh42H avatar Jul 11 '24 15:07 purnesh42H

@dfawley this looks good to be merged

purnesh42H avatar Jul 12 '24 09:07 purnesh42H