Grab comment from proto file, similar to protoc-gen-go

[RedHawker]

Adding initial code. grabs the header comment from the FileDescriptor This code was copied from the main protoc-gen-go code

Attempts to address #5530

It's quick and dirty, but I'm going people who know better about the project can suggest a better way.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: RedHawker (c8b2ebef0d3face7f8600612b6c8a7ec37453dfe, 9ef49fc186cbde855ed984fd92ae0aee19de61ab, 3962abac0b66a2f2212613b7eafb59b5c1bdbdc9, bee0d735d4e98442a64cb62664f60dd6370fbdba)

[github-actions[bot]]

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

[RedHawker]

The vet-proto step fails in the checks with the proposed changes, what needs to change to allow for them to work with the generated files now containing the additional comment(s)?

[dfawley]

The vet-proto step fails in the checks with the proposed changes, what needs to change to allow for them to work with the generated files now containing the additional comment(s)?

Changes to the code generator will require that you re-run ./regenerate.sh from the root of the repo. That will also give us a preview of how the generated code looks.

[RedHawker]

The vet-proto step fails in the checks with the proposed changes, what needs to change to allow for them to work with the generated files now containing the additional comment(s)?

Changes to the code generator will require that you re-run ./regenerate.sh from the root of the repo. That will also give us a preview of how the generated code looks.

I ran regenerate.sh but it doesn't run in a container, so it uses my system's protoc version instead of 3.14.0 that's in the existing files.

[dfawley]

I ran regenerate.sh but it doesn't run in a container, so it uses my system's protoc version instead of 3.14.0 that's in the existing files.

Would you mind downloading that version and making sure it gets run instead?

      PROTOBUF_VERSION=3.14.0
      PROTOC_FILENAME=protoc-${PROTOBUF_VERSION}-linux-x86_64.zip
      pushd /home/travis
      wget https://github.com/google/protobuf/releases/download/v${PROTOBUF_VERSION}/${PROTOC_FILENAME}

[RedHawker]

I don't know why those tests are failing, they seem unrelated to my changes as far as I can tell.

[github-actions[bot]]

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

[github-actions[bot]]

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

[RedHawker]

I'm not sure what else needs to be done?

[easwars]

Thank you for the PR !!

[andremarianiello]

Now that this is fixed, is there going to be a new version tag for protoc-gen-go-grpc?

[easwars]

Now that this is fixed, is there going to be a new version tag for protoc-gen-go-grpc?

Yes, we will get that out soonish. Filed https://github.com/grpc/grpc-go/issues/6060 to track.

[arvindbr8]

Hi @andremarianiello, you should find the fix included in our latest release of proto-gen-go-gRPC. Please feel free to reach out if there are any concerns.