grpc-dart icon indicating copy to clipboard operation
grpc-dart copied to clipboard

Fix null custom headers

Open hiro-at-pieces opened this issue 3 months ago • 5 comments

hiro-at-pieces avatar Sep 01 '25 21:09 hiro-at-pieces

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: hiro-at-pieces / name: hiro-at-pieces (6808561f99f90f7c3394fd3efb6c74e87caf6342, a25aa7edf7b0f0d6e1117f8ab881901e89d1f1fa)

You need to sign CLA otherwise we can't even look your patch.

mraleph avatar Sep 02 '25 12:09 mraleph

You need to sign CLA otherwise we can't even look your patch.

@mraleph I just signed EasyCLA. Let me know if you have any questions

hiro-at-pieces avatar Sep 02 '25 14:09 hiro-at-pieces

Is this to solve https://github.com/grpc/grpc-dart/issues/736? From the discussion there, I don't believe this is the right fix. Could you elaborate?

mosuem avatar Sep 02 '25 17:09 mosuem

PR Health

Breaking changes :heavy_check_mark:
Package Change Current Version New Version Needed Version Looking good?
grpc None 4.2.0 4.2.0 4.2.0 :heavy_check_mark:

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry :exclamation:
Package Changed Files
package:grpc lib/src/server/handler.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks :warning:

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
grpc $1.Duration generated/google/rpc/error_details.pb.dart::RetryInfo::retryDelay
generated/google/protobuf/duration.pb.dart::Duration::clone
generated/google/protobuf/duration.pb.dart::Duration::copyWith
generated/google/protobuf/duration.pb.dart::Duration::create
generated/google/protobuf/duration.pb.dart::Duration::createEmptyInstance
generated/google/protobuf/duration.pb.dart::Duration::createRepeated
generated/google/protobuf/duration.pb.dart::Duration::getDefault
generated/google/rpc/error_details.pb.dart::RetryInfo::retryDelay
generated/google/rpc/error_details.pb.dart::RetryInfo::ensureRetryDelay
generated/google/rpc/error_details.pb.dart::RetryInfo::new::retryDelay

This check can be disabled by tagging the PR with skip-leaking-check.

github-actions[bot] avatar Sep 02 '25 17:09 github-actions[bot]