go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

introduce errorLogFunc in opentracing options

Open andrey-berenda opened this issue 3 years ago • 2 comments

Issue #391

andrey-berenda avatar Jul 27 '22 16:07 andrey-berenda

Hi, I believe we want this functionality against the v2 branch, not master. Could you try to rewrite this against that branch? CC @bwplotka

johanbrandhorst avatar Jul 28 '22 05:07 johanbrandhorst

Codecov Report

Merging #508 (79bacc9) into v2 (6e2c2ac) will decrease coverage by 25.52%. The diff coverage is 50.46%.

@@             Coverage Diff             @@
##               v2     #508       +/-   ##
===========================================
- Coverage   84.01%   58.48%   -25.53%     
===========================================
  Files          30       30               
  Lines         932     1573      +641     
===========================================
+ Hits          783      920      +137     
- Misses        110      590      +480     
- Partials       39       63       +24     
Impacted Files Coverage Δ
chain.go 0.00% <ø> (-90.91%) :arrow_down:
interceptors/auth/auth.go 100.00% <ø> (ø)
interceptors/ratelimit/ratelimit.go 60.00% <0.00%> (-40.00%) :arrow_down:
interceptors/recovery/options.go 78.57% <ø> (ø)
metadata/single_key.go 60.00% <ø> (ø)
testing/testpb/interceptor_suite.go 0.00% <0.00%> (ø)
testing/testpb/test.manual_validator.pb.go 0.00% <0.00%> (ø)
util/backoffutils/backoff.go 60.00% <ø> (ø)
wrappers.go 66.66% <ø> (-33.34%) :arrow_down:
interceptors/reporter.go 45.45% <20.00%> (-17.05%) :arrow_down:
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d0f5fe...79bacc9. Read the comment docs.

codecov-commenter avatar Jul 28 '22 05:07 codecov-commenter

Amazing work, this is how we would do it.. if the issue would be still relevant.

Mentioned details in https://github.com/grpc-ecosystem/go-grpc-middleware/issues/391

Thanks anyway, great job! 🤗

bwplotka avatar Mar 18 '23 10:03 bwplotka