go-grpc-middleware
go-grpc-middleware copied to clipboard
grpc-ecosystem
v2: Please provide (port) grpc_logsettable.SettableLoggerV2 in go-grpc-middleware/v2
Unfortunately v2 doesn't have SettableLoggerV2 nor has APIs for setting global gRPC logger, as a matter of fact. Only interceptor logs are available on the branch which will not produce framework level logs.
We rely on SettableLoggerV2 for setting global grpc logger to zap logger and reset it back as needed.
Please let me know if you need any further information.
I was doing some research and found this comment https://github.com/grpc-ecosystem/go-grpc-middleware/pull/402#issue-831821664.
Is setting grpc logger via grpc.SetLoggerV2() not something we do not want in v2 at all?
I would have to defer to @bwplotka who implemented most of the logging changes 😁
I am failing to understand what global grpc Logger has to do with interceptors (even logging interceptor) 🤔
Do you mind giving us TL;DR on how this repo (on v2 branch) is limiting you on using https://pkg.go.dev/google.golang.org/grpc/grpclog#SetLoggerV2 in your code? Thanks 🤗
Closing for now, since we didn't hear from you - we can always open, thanks! (: