go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

v2: Not all tests are executed on macOS

Open ash2k opened this issue 4 years ago • 3 comments

https://github.com/grpc-ecosystem/go-grpc-middleware/runs/2203038390?check_suite_focus=true#step:5:6

There is an issue in the makefile.

ash2k avatar Apr 21 '21 00:04 ash2k

This issue has been addressed by #413 so closing. Let me know if this needs to be opened :)

yashrsharma44 avatar Apr 26 '21 08:04 yashrsharma44

I'm sorry, but it was not addressed - I was not fixing it. It's still happening e.g. https://github.com/grpc-ecosystem/go-grpc-middleware/runs/1895406088?check_suite_focus=true#step:5:7

ash2k avatar Apr 26 '21 09:04 ash2k

Ok, here is a recent test run https://github.com/grpc-ecosystem/go-grpc-middleware/runs/2436081775?check_suite_focus=true#step:5:6

ash2k avatar Apr 26 '21 09:04 ash2k

We can't see logs (too old) ): Let's make sure to paste exact problem next time.

bwplotka avatar Mar 19 '23 01:03 bwplotka

All tests pass for both make test and go test ./... for me locally. Apple M1 Pro macOS 13.6 (22G120).

aboryslawski avatar Oct 06 '23 08:10 aboryslawski

Unless @ash2k is referring to some specific tests that are omitted.

aboryslawski avatar Oct 06 '23 08:10 aboryslawski

Well, I don't remember what the problem was.

ash2k avatar Oct 06 '23 09:10 ash2k