go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

v2: Switch `grpclog.Infof` with something non-global

Open bwplotka opened this issue 4 years ago • 1 comments

There is no way to control this on instance lvl, it's only global. Let's fix this.

e.g grpclog.Infof("grpc_opentracing: failed parsing trace information: %v", err) in tracing package.

Not blocking v2 release, we can do later.

bwplotka avatar Jan 30 '21 19:01 bwplotka

@bwplotka I have created the pr could you watch it?

andrey-berenda avatar Aug 13 '22 22:08 andrey-berenda

Thanks for the PR, but this is now done, because we decided to remove opentracing completely. It is deprecated (if needed opentracing from v1 can be used) and otherwise users can use otlpgrpc (:

Thanks anyway, and sorry we didn't notice this earlier!

bwplotka avatar Mar 18 '23 10:03 bwplotka