go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Generate changelog from makefile

Open johanbrandhorst opened this issue 5 years ago • 1 comments

In the same vein as the grpc-gateway, simply generate the changelog. Reduces the amount of work involved in making a new release and general maintenance, at the cost of a neatly curated changelog. Opinions welcome.

Steps for making a new release (with this):

  1. Create a new branch, generate CHANGELOG.md with
    $ NEW_RELEASE=<new_release> CHANGELOG_GITHUB_TOKEN=<token> make changelog
    
  2. Merge CHANGELOG.md changes.
  3. Tag new release at the new commit.

johanbrandhorst avatar Feb 11 '20 11:02 johanbrandhorst

Codecov Report

Merging #266 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          42       42           
  Lines        1574     1574           
=======================================
  Hits         1154     1154           
  Misses        366      366           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d961ee...c9a0de5. Read the comment docs.

codecov-io avatar Feb 11 '20 11:02 codecov-io

Nice, I proposed removing it, let me know if this makes sense: https://github.com/grpc-ecosystem/go-grpc-middleware/pull/542

Rationale: GH releases allows nice generation of CHANGELOG straight there.

bwplotka avatar Mar 14 '23 20:03 bwplotka

Alternative was merged, closing.

bwplotka avatar Mar 15 '23 10:03 bwplotka