go-grpc-middleware Support grpc

Support grpc_glog ?

Open tamalsaha opened this issue 7 years ago • 4 comments

Does it sound reasonable to support a logging implementation using glog ? We currently use glog and would like to use that for grpc logger.

Feb 21 '18 04:02 tamalsaha

Submit a PR I'm sure the team will take a look 👍

Feb 23 '18 20:02 domgreen

Thanks @domgreen . I have filed #129 for this.

Feb 26 '18 22:02 tamalsaha

I assume you're talking about grpcloggerv2 from the grpc-go repo?

Mar 31 '18 11:03 mwitkow

I used grpcloggerv2 interface so that I can write tests for it, without inventing a new interface for testing.

Apr 01 '18 08:04 tamalsaha

Let us know if this still needed - it's quite an old issue (: Also see v2 if you want to contribute this.

Mar 19 '23 01:03 bwplotka