Transportr icon indicating copy to clipboard operation
Transportr copied to clipboard

Improved Readme

Open aha999 opened this issue 4 years ago • 8 comments

I have improved readme by adding new content like new high resolution download icons, gif next to the screenshots, donation info, contribution info etc. generally it looks and functions better. It was made because of the issue #777

You can see it in my fork: https://github.com/aha999/Transportr

aha999 avatar Nov 08 '21 22:11 aha999

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement, and we don't seem to have the user @aha999 on file. In order for your code to get reviewed and merged, please explicitly state that you accept the agreement. Alternatively, you can add a commit that adds yourself to https://github.com/grote/Transportr/blob/master/.clabot

cla-bot[bot] avatar Nov 08 '21 22:11 cla-bot[bot]

I accept the agreement

aha999 avatar Nov 09 '21 11:11 aha999

This PR conflicts with the current master branch, so for a merge this would need to be resolved. Also why make that much changes in the readme? To me it would be sufficient to replace the F-Droid and PlayStore badges, and maybe the move the Transportr logo to the top.

Altonss avatar May 23 '23 20:05 Altonss

Also, with these changes every load of the README issues a lot of third-party requests. Not sure if we'd want that.

ialokim avatar May 23 '23 20:05 ialokim

Also, with these changes every load of the README issues a lot of third-party requests. Not sure if we'd want that.

Are those really generating third-party requests? Are they not loaded through github servers?

Altonss avatar May 23 '23 20:05 Altonss

Also, with these changes every load of the README issues a lot of third-party requests. Not sure if we'd want that.

Are those really generating third-party requests? Are they not loaded through github servers?

At least when looking at the (rendered) Markdown locally.

ialokim avatar May 23 '23 20:05 ialokim

@Altonss i make that many merges, because i don't change everything in one try, so sometimes i save and continue later. Which 3'rd party requests are we talking about?

aha999 avatar Jun 04 '23 19:06 aha999

I just double-checked and after the changes, the README only loads images additionally from shields.io. I think that's actually fine with me.

ialokim avatar Aug 13 '23 19:08 ialokim